Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shift not working correctly when horizontal is true #412

Closed
tonymontana97 opened this issue Mar 16, 2024 · 2 comments
Closed

shift not working correctly when horizontal is true #412

tonymontana97 opened this issue Mar 16, 2024 · 2 comments

Comments

@tonymontana97
Copy link
Sponsor

Is your feature request related to a problem? Please describe.
We use virtua for our horizontal infinity virtualised list, initial position always middle of list, when user reach start of virtualised list, we prepend new items, but after prepending with enabled shift, scroll position restoring in middle of list and it's visible for eyes.

Describe the solution you'd like
Looks like shifting not working for horizontal prepending of elements, I think we can make next: when shifting is true and horizontal scroll enabled, then after prepending of new items restore scroll position on difference between scrollSize, I have made this by myself, but cool if you implement it from box

Additional context
This library if perfect solution for our application. We have try more than 5 different libraries including react-window, but virtua is the best, really. Thanks you!

@inokawa
Copy link
Owner

inokawa commented Mar 17, 2024

Hi, thank you for trying my lib!

I've made a horizontal reverse infinite scrollable list in my local with virtua 0.29.0 and it works fine.
Could you make a minimal reproduction, or give me more detailed information of your situation?

horizontal.reverse.infinite.scroll.mov

@tonymontana97
Copy link
Sponsor Author

@inokawa Sorry, issue was on our side, also we replace Virtualizer with VList, VList has restoration.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants