Improve smoothness of smooth scrolling #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inokawa
force-pushed
the
smooth-measure
branch
2 times, most recently
from
4a4db76
to
88f7a2c
Compare
inokawa
force-pushed
the
smooth-measure
branch
from
88f7a2c
to
d1af69c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #14
fix #221
This PR will change smooth scrolling algorithm to mount all items between start and end for measuring before scrolling.
It may sound that it affects performance, but it will not have much difference because almost all items between start and end will be mounted during smooth scrolling even if we didn't do it manually.