Add ability to keep offscreen items mounted #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inokawa
approved these changes
Apr 13, 2024
There was a problem hiding this comment.
@mariia-mitiureva
I was thinking of a bit more complicated one, but probably this will be enough for most use cases.
Thank you for the PR!
|
Released in |
takecchi
pushed a commit
to cuculus-dev/cuculus
that referenced
this pull request
Apr 17, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [virtua](https://togithub.com/inokawa/virtua) | [`0.29.2` -> `0.30.0`](https://renovatebot.com/diffs/npm/virtua/0.29.2/0.30.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | @coderabbitai: ignore --- ### Release Notes <details> <summary>inokawa/virtua (virtua)</summary> ### [`v0.30.0`](https://togithub.com/inokawa/virtua/releases/tag/0.30.0) [Compare Source](https://togithub.com/inokawa/virtua/compare/0.29.2...0.30.0) #### What's Changed - Add ability to keep offscreen items mounted by [@​mariia-mitiureva](https://togithub.com/mariia-mitiureva) in [inokawa/virtua#429 #### New Contributors - [@​mariia-mitiureva](https://togithub.com/mariia-mitiureva) made their first contribution in [inokawa/virtua#429 **Full Changelog**: inokawa/virtua@0.29.2...0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cuculus-dev/cuculus). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #181
This simple change fixes a number of issues with off-screen elements:
But I'm guessing you wanted to find a generic solution that covers more use cases, right?
This seems to solve the most critical issues for me. The new prop could be added with
unstable_orexperimental_prefix, until you find a better solution, what do you think?