Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font size is wrong #73

Closed
bendem opened this issue Mar 15, 2023 · 5 comments
Closed

Font size is wrong #73

bendem opened this issue Mar 15, 2023 · 5 comments

Comments

@bendem
Copy link

bendem commented Mar 15, 2023

I don't know how the images are rendered, but it looks like the fonts are not specified and it picks up default from somewhere. I have large fonts enabled anywhere I can for reasons. This is the output generated right after install with no customization applied yet:

status:
git-sim-status_03-15-23_14-41-10
merge:
git-sim-merge_03-15-23_14-52-10

System infos:

> cat /etc/system-release
Rocky Linux release 8.7 (Green Obsidian)

> uname -r
5.15.90.1-microsoft-standard-WSL2

> dnf list --installed ffmpeg cairo pango | cat
Installed Packages
cairo.x86_64                1.15.12-6.el8                @appstream
ffmpeg.x86_64               4.2.8-1.el8                  @rpmfusion-free-updates
pango.x86_64                1.42.4-8.el8                 @appstream

> pipx list
venvs are in /home/demarteaub/.local/pipx/venvs
apps are exposed on your $PATH at /home/demarteaub/.local/bin
   package git-sim 0.2.7, installed using Python 3.9.13
    - git-dummy
    - git-sim
@bendem
Copy link
Author

bendem commented Mar 15, 2023

Same problem when running in docker so my guess about it using my system settings seems off the table.

@bendem
Copy link
Author

bendem commented Mar 15, 2023

bisect:

3533002e3e726fa991038aca347c51d5f208b8c6 is the first bad commit
commit 3533002e3e726fa991038aca347c51d5f208b8c6
Author: Jacob Stopak <[email protected]>
Date:   Tue Feb 28 16:38:57 2023 -0800

    Refactor all subcommands to accomodate new diverse branching system

    Signed-off-by: Jacob Stopak <[email protected]>

 git_sim/add.py                  |   3 +-
 git_sim/branch.py               |   2 +-
 git_sim/cherrypick.py           |   4 +-
 git_sim/commit.py               |   3 +-
 git_sim/git_sim_base_command.py | 146 ++++++++++++++++++++++++------------
 git_sim/log.py                  | 162 ----------------------------------------
 git_sim/merge.py                |   7 +-
 git_sim/rebase.py               |   7 +-
 git_sim/reset.py                |   9 ++-
 git_sim/restore.py              |   3 +-
 git_sim/revert.py               |   8 +-
 git_sim/stash.py                |   3 +-
 git_sim/status.py               |   3 +-
 git_sim/tag.py                  |   2 +-
 14 files changed, 127 insertions(+), 235 deletions(-)

@initialcommit-io
Copy link
Contributor

@bendem Thanks for reporting this.

I believe this is a regression issue that only happens in repos with less than 5 commits. I had originally fixed this but then overhauled the commit-parsing method, so I think I need to fix it again.

If you test on a repo with more than 5 commits I don't think you'll have this issue. I'll let you know when it's fixed. Let me know if any other questions about it.

@initialcommit-io
Copy link
Contributor

Just released a fix for this! Please use git-sim version 0.2.9 to take advantage of the fixes. You can upgrade git-sim with: pip install git-sim --upgrade.

I'll close this for now since it's implemented, but please let me know if you have any questions or run into any issues!

@bendem
Copy link
Author

bendem commented Apr 3, 2023

Perfection! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants