fix(input.redis): Discard invalid errorstat lines #15312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicois
force-pushed
the
nicois/handle-invalid-errorstats
branch
2 times, most recently
from
8f3b59b
to
f0f9981
Compare
nicois
changed the title
nicois
changed the title
nicois
changed the title
srebhan
changed the title
telegraf-tiger
bot
added
area/redis
plugin/input
srebhan
reviewed
May 7, 2024
There was a problem hiding this comment.
Thanks for your contribution @nicois! I would prefer to add errors instead of debug logs as this simplifies code, make users more aware and is discoverable on the database side when using the inputs.internal plugin.
What do you think?
srebhan
changed the title
nicois
force-pushed
the
nicois/handle-invalid-errorstats
branch
from
3ef2f94
to
3c0c0ae
Compare
…#15311) Some badly-behaved sources (such as dragonfly) may send error messages which are not in the expected format. If errorstat lines are found which do not include an `=` sign, silently discard them. Somewhere between 1.26 and 1.28.5, a change was made which caused such missing '=' symbols to cause a panic. In addition to ignoring such entries, add debug-level logging for this and a similar problem, where the errorstat values are not base-10.
nicois
force-pushed
the
nicois/handle-invalid-errorstats
branch
from
3c0c0ae
to
86946df
Compare
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
approved these changes
May 7, 2024
srebhan
added
the
ready for final review
powersj
approved these changes
May 7, 2024
powersj
pushed a commit
that referenced
this pull request
May 20, 2024
(cherry picked from commit 7f4d27d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some badly-behaved sources (such as dragonfly) may send error messages which are not in the expected format. If errorstat lines are found which do not include an
=sign, silently discard them.Somewhere between 1.26 and 1.28.5, a change was made which caused such missing '=' symbols to cause a panic.
In addition to ignoring such entries, add debug-level logging for this and a similar problem, where the errorstat values are not base-10.
Checklist
Related issues
resolves #15311