Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you use this in production? #14

Open
keegancsmith opened this issue Feb 21, 2018 · 2 comments
Open

Do you use this in production? #14

keegancsmith opened this issue Feb 21, 2018 · 2 comments

Comments

@keegancsmith
Copy link

Hello, I came across this lib when looking up using srv records in Go. I was interested if you use this in production? If so at what scale and with what DNS provider? I am assuming kubernetes based on some of the other projects. I guess I am hoping for some understanding how hard one can hit the DNS server in k8s and how reliable that is. Currently I have some code which uses the k8s API, but that is a very heavyweight dependence. Just using SRV is very attractive to me.

@GeertJohan
Copy link

grpc-go now supports SRV records out of the box.
https://github.com/grpc/grpc-go/blob/master/resolver/dns/dns_resolver.go#L195

Although this was a useful package, I believe this package should be deprecated in favor of official grpc-go support.
Also, this depends on grpc-go packages that have already been deprecated.

@bwplotka
Copy link
Contributor

bwplotka commented Nov 29, 2018

Yes. It Is running on production in various places for quite a long time (: Works well, even by using naive polling.

grpc-go now supports SRV records out of the box.

This is great, and seems like default option, especially when you use tip of gRPC.

Worth to mention that this library is used also for general dns watcher logic that depends on TTL (or custom frequency), so we cannot use gRPC DNS resolver which resolves only every 30 minutes, with some ResolveNow. It might fit into gRPC logic, but is not generally flexible.

It might be worth to get more info about grpc-go dns_resolver logic, especially interested in seeing more info about this: grpc/grpc-go#2279 (comment) Because if we have such frequency like 30 min and ResolveNow logic for adhoc resolutions, why even having background watcher logic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants