-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript types for params
#308
Comments
Oh, I read the angular projet code and typing of params is generated with It may be a solution. |
Salut @sylcastaing, just letting you know that I didn't miss this, and we're still discussing this internally. Of course we'd love a PR for this if you have the time! |
Hi @sylcastaing 👋 we would love to have some type params for |
Hello team,
All my company's projects that use Imgix are written in typescript.
Before, we use react-imgix with @types/react-imgix.
In
@types/react-imgix
there are type for all Imgix Params types. Not pretty but it's good for IDE autocompletation and help very much my team.What do you think about port the types of
imgixParams
tojs-core
?It can be usefull to have, in the future, embed types pointing to
js-core
typing for all others projets (react-imgix, angular, etc..)I can, of course, make a PR for this !
The text was updated successfully, but these errors were encountered: