Implement Presentation Model Pattern #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohbus
suggested changes
Apr 22, 2021
There was a problem hiding this comment.
Thank you so much @EdisonE3 for your valuable contribution!
Please take a note of the following points:
- Increase Code Coverage try making it to 100%
- Use Logger to show some verbose logging of the work that is being done. Take a look at other implemented patterns to get an idea.
- Remove the Code Smells as reported by Sonar, let us know if there are any false positives.
Good Luck 👍🏻
Comment on lines
3
to
7
| /** | ||
| *A class used to store the information of album. | ||
| * | ||
| * @author EdisonE3 | ||
| */ |
Comment on lines
15
to
30
| /** | ||
| * The constructor method of Album. | ||
| * | ||
| * @param rowId the id of the album | ||
| * @param title the title of the album | ||
| * @param artist the name of artist | ||
| * @param isClassical whether the album is classical | ||
| * @param composer the name of composer | ||
| */ | ||
| public Album(int rowId, String title, String artist, boolean isClassical, String composer) { | ||
| this.rowId = rowId; | ||
| this.title = title; | ||
| this.artist = artist; | ||
| this.isClassical = isClassical; | ||
| this.composer = composer; | ||
| } |
There was a problem hiding this comment.
Use lombok for boilerplate code
Comment on lines
3
to
7
| /** | ||
| * a class used to start this demo. | ||
| * | ||
| * @author EdisonE3 | ||
| */ |
Comment on lines
6
to
10
| /** | ||
| * a class used to deal with albums. | ||
| * | ||
| * @author EdisonE3 | ||
| */ |
Comment on lines
3
to
7
| /** | ||
| * The class between view and albums, it is used to control the data. | ||
| * | ||
| * @author EdisonE3 | ||
| */ |
Comment on lines
87
to
89
|
|
||
|
|
||
|
|
Comment on lines
14
to
18
| /** | ||
| * Generates the GUI of albums. | ||
| * | ||
| * @author EdisonE3 | ||
| */ |
|
Thanks a lot! |
ohbus
suggested changes
Apr 26, 2021
iluwatar
requested changes
May 2, 2021
presentation/pom.xml
Outdated
Comment on lines
71
to
78
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-pmd-plugin</artifactId> | ||
| <configuration> | ||
| <linkXRef>false</linkXRef> | ||
| </configuration> | ||
| <version>3.14.0</version> | ||
| </plugin> |
There was a problem hiding this comment.
Not needed, we use SonarCloud for static analysis
|
Thanks for your advices, I will try to make it better. |
|
Hello, the changes requested have been finished. @ohbus |
|
Kudos, SonarCloud Quality Gate passed! |
|
@all-contributors please add @EdisonE3 for code |
|
I've put up a pull request to add @EdisonE3! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presentation Model Pattern
-Implemented Registry pattern addressing the issue #415
Description
-Represent the state and behavior of the presentation independently of the GUI controls used in the interface