Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change trade management #8

Open
ilcardella opened this issue Oct 15, 2018 · 0 comments
Open

Change trade management #8

ilcardella opened this issue Oct 15, 2018 · 0 comments

Comments

@ilcardella
Copy link
Owner

broker.trade(epic, trade.name, limit, stop)

Rather than trade each epic one by one after finding a valid signal, the script could build a list with the info returned by the find_trade_signal() (epic, tradeDirection, limit and stop). Then at then of the epic_list for loop, it could iterate along the list and take trade actions.
This is helpful because we might want to add other check before trading.

Still need to evaluate the real benefit of this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant