Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithreading issue on GzipChannel write header #79

Closed
creyer opened this issue Sep 27, 2023 · 1 comment
Closed

Multithreading issue on GzipChannel write header #79

creyer opened this issue Sep 27, 2023 · 1 comment

Comments

@creyer
Copy link

creyer commented Sep 27, 2023

When having multiple instances of WarcWriter the operations on
private static final ByteBuffer GZIP_HEADER = ByteBuffer.wrap(GZIP_HEADER_); are causing issues.
Some threads are writing the gzip header, some might not.

I think the issue could be fixed by removing the static part for the GZIP_HEADER.

@ato
Copy link
Member

ato commented Sep 28, 2023

Yikes. Good catch.

Suggested fix applied in 68575d4 and released as 0.28.3.

@ato ato closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants