-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Change Office365 Webhook to Teams Workflow #350
Comments
I have run into that error, tried escaping the '%' and now I have a status code 202 on the request |
We are currently investigating. |
Microsoft Power Automate web interface show me this error: |
Hi, I have some experience on Power Automate workflow. You can decode the webhook URL from Workflow to string, not URI. I use the function "decodeURIComponent" in javascript to decode the URI ex. and you must change the Adaptive card template like this |
I confirm this behaviour...receiving 202 status code too upon changing the URL to the accepted format.
|
I think it should be fairly safe to update the client to also accept 202 as a valid response. I'm more concerned about changing the template. I guess that updating the template to the new variant would break existing webhook calls, but I'm not too sure about that. |
I've been looking into updating the template and noticed that the impact is high. If my understanding is correct, the POST call that this project uses is on with a type The template from @toygame works also on the existing endpoints (tested with https://.webhook.office.com) so that would not be an issue. Hence I think it only takes some effort to convert the template & update all the tests. Not so sure what others think of this? |
Hello! We will be looking into fixing this soon, but if you have something working already, feel free to contribute and open a PR :) |
@xtianae7 I've been able to make good progress, however, I face two issues:
|
I'm still facing this issue installing via helm chart ( https://github.com/idealista/prom2teams/tree/develop/helm ) and using Passing the url of the Workflow connector replacing '%' escaped with '%%' in values for I see this issue closed as completed, Will be a new image released with this fix? |
Description
Microsoft recently added the following message when using the Office365 Connector. "Action Required:
O365 connectors within Teams will be deprecated and notifications from this service will stop.
Learn more
about the timing and how the Workflows app provides a more flexible and secure experience. If you want to continue receiving these types of messages, you can use a workflow to post messages from a webhook request.
Set up workflow".
When following the recommended steps we started receiving the following error when trying to execute the post "configparser.InterpolationSyntaxError: '%' must be followed by '%' or '(', found: '%2Fmanual%%2Frun&sv=1.0&sig=mXASDASsaPihsdaARjeknv' "
Apparently there is an error in the webhook url that contains '%'
Steps to Reproduce
Expected behavior:
Send message to Teams Channel
Actual behavior:
Error above
File "/usr/local/lib/python3.8/configparser.py", line 395, in before_get
2024-07-10T10:13:16.777425044-03:00 self._interpolate_some(parser, option, L, value, section, defaults, 1)
2024-07-10T10:13:16.777428260-03:00 File "/usr/local/lib/python3.8/configparser.py", line 442, in _interpolate_some
2024-07-10T10:13:16.777431522-03:00 raise InterpolationSyntaxError(
2024-07-10T10:13:16.777434864-03:00 configparser.InterpolationSyntaxError: '%' must be followed by '%' or '(', found:
Reproduces how often:
100% of time
Environment
The text was updated successfully, but these errors were encountered: