Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DET HybridSampler with Constant and Dependent Variables #2031

Merged
merged 6 commits into from
Jan 12, 2023
Merged

Conversation

wangcj05
Copy link
Collaborator


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

close #2025

What are the significant changes in functionality due to this change request?

Enable DET HybridSampler to handle constant and dependent variables


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

Copy link
Collaborator

@aalfonsi aalfonsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some verbose doctoring for the 2 variables that have been added

@wangcj05
Copy link
Collaborator Author

@mandd @aalfonsi This PR is ready to be reviewed. Please let me know if you have any comments.

@moosebuild
Copy link

Job Test CentOS 8 on afe93c6 : invalidated by @wangcj05

@wangcj05
Copy link
Collaborator Author

DIFF in tests/framework/PostProcessors/EconomicRatio/economicRatioTimeDependent/datasetPrint.csv: 
  Columns are not the same! Different: targets, Unnamed: 1
(334F1/831) Diff   (  3.62sec)tests/framework/PostProcessors/EconomicRatio/timeDepDataset

It seems this test failed randomly, it need to be investigated.

@wangcj05 wangcj05 added Ready To Review RAVENv2.3 for RAVEN 2.3 Release labels Jan 11, 2023
@aalfonsi aalfonsi merged commit 8f4f98b into devel Jan 12, 2023
@aalfonsi aalfonsi deleted the wangc/det branch January 12, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RAVENv2.3 for RAVEN 2.3 Release Ready To Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEFECT] Constant and Redundant Variables handling in DET
3 participants