Ensemble model fixes for batching #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job Test qsubs sawtooth on ad894b9 : invalidated by @wangcj05 one failed run for tests/cluster_tests/InternalParallel/test_hybrid_model_code |
|
Job Test qsubs sawtooth on ad894b9 : invalidated by @joshua-cogliati-inl fixed problem on sawtooth |
|
Job Mingw Test on ad894b9 : invalidated by @wangcj05 retesting |
wangcj05
requested changes
Nov 15, 2022
| if output.name not in optionalOutputNames: | ||
| if output.name not in targetEvaluationNames.keys(): | ||
| output.addRealization(joinedResponse) | ||
| if isinstance(evaluation,dict): |
There was a problem hiding this comment.
Could you update this line with followings:
# in the event a batch is run, the evaluations will be a dict as {'RAVEN_isBatch':True, 'realizations': [...]}
if isinstance(evaluation,dict) and evaluation.get('RAVEN_isBatch',False):| metadata = kw | ||
|
|
||
| if self.parallelStrategy == 1: | ||
| jobHandler.addJob((self, myInput, samplerType, kw), self.__class__.evaluateSample, prefix, metadata=metadata, |
There was a problem hiding this comment.
In addition, we need add a test for this PR to test the GA with ensemble model
wangcj05
requested changes
Nov 18, 2022
| <?xml version="1.0" ?> | ||
| <Simulation verbosity="debug"> | ||
| <TestInfo> | ||
| <name>framework/Optimizers/GeneticAlgorithms/test_ensemble_withGA</name> |
There was a problem hiding this comment.
classesTested node is required. Could you add that?
wangcj05
approved these changes
Nov 18, 2022
10 tasks
|
PR looks good and checklist is satisfied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
What are the significant changes in functionality due to this change request?
close #2019
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.raven/tests/framework/user_guideandraven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.