Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensemble Rom #1720

Merged
merged 30 commits into from
Jan 17, 2022
Merged

Ensemble Rom #1720

merged 30 commits into from
Jan 17, 2022

Conversation

wangcj05
Copy link
Collaborator

@wangcj05 wangcj05 commented Nov 20, 2021


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

close #1722

The goal of ensemble ROMs (estimators) is to combine the predictions of several base ROMs (estimators) built with a given learning algorithm in order to improve generalizability / robustness over a single ROM.

Two families of ensemble ROMs are usually distinguished:

In averaging methods, the driving principle is to build several estimators independently and then to average their predictions. On average, the combined estimator is usually better than any of the single base estimator because its variance is reduced.

Examples: Bagging methods, Forests of randomized trees, …

By contrast, in boosting methods, base estimators are built sequentially and one tries to reduce the bias of the combined estimator. The motivation is to combine several weak models to produce a powerful ensemble.

Examples: AdaBoost, Gradient Tree Boosting, …

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@wangcj05 wangcj05 changed the title Ensemble Rom WIP: Ensemble Rom Nov 23, 2021
@wangcj05 wangcj05 changed the title WIP: Ensemble Rom Ensemble Rom Nov 23, 2021
@wangcj05 wangcj05 changed the title Ensemble Rom WIP: Ensemble Rom Nov 23, 2021
@wangcj05 wangcj05 changed the title WIP: Ensemble Rom Ensemble Rom Nov 24, 2021
@moosebuild
Copy link

Job Test qsubs falcon on 09fd2e0 : invalidated by @wangcj05

missing conda environment

@wangcj05 wangcj05 requested a review from mandd November 24, 2021 18:58
@moosebuild
Copy link

Job Test qsubs falcon on bae6738 : invalidated by @wangcj05

rerun

@@ -131,7 +131,6 @@ def _initializeLSpp(self, runInfo, inputs, initDict):
self.ROM.initializeModel(settings)
else:
self.ROM = self.assemblerDict['ROM'][0][3]
self.ROM.reset()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes me pretty nervous. What else changed that supports removing this reset?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just do not see the value for the reset here, it seems to me it is at the initialization stage, the ROM is initialized during this stage, why do we need to reset it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I don't disagree. I wonder why it was added in the first place.

@wangcj05 wangcj05 added RAVENv2.2 for RAVENv2.2 Release Ready To Review labels Dec 1, 2021
@moosebuild
Copy link

Job Test qsubs sawtooth on bae6738 : invalidated by @wangcj05

1 similar comment
@moosebuild
Copy link

Job Test qsubs sawtooth on bae6738 : invalidated by @wangcj05

@wangcj05
Copy link
Collaborator Author

wangcj05 commented Jan 5, 2022

@mandd Do you have time to review this PR?

@mandd
Copy link
Collaborator

mandd commented Jan 17, 2022

PR is green to me. Merging

@mandd mandd merged commit f941138 into idaholab:devel Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RAVENv2.2 for RAVENv2.2 Release Ready To Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Add Ensemble ROM Capability
4 participants