Failure with GA

[aalfonsi]

---

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #1676

What are the significant changes in functionality due to this change request?

Allow the GA to handle the failure

---

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

• 1. Review all computer code.
• 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
• 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
• 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
• 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
• 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
• 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
• 8. If an analytic test is changed/added is the the analytic documentation updated/added?
• 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

[wangcj05]

Changes are good to me. One question: is it possible to add a test? @aalfonsi
@mandd @Jimmy-INL Do you have any comments on this PR?

[aalfonsi]

@wangcj05 Yes, if it is possible, I would like Diego (@mandd) and Mohammad (@Jimmy-INL) to test this with imposed failures (of the model) to see if the behavior of the optimizer is as expected (I am not super sure).

[moosebuild]

Job Test mac on 29e6333 : invalidated by @aalfonsi

[aalfonsi]

@Jimmy-INL @mandd

Are we good with this? The Mac test machine does not look like to work. I tested on my MAC and everything PASS:

PASSED: 676
SKIPPED: 86
FAILED: 0
 ... RAVEN tests passed successfully.

[moosebuild]

Job Test mac on b0bcbeb : invalidated by @Jimmy-INL

[Jimmy-INL]

I am OK with this PR, @aalfonsi please generate an issue to address the random failures.

[aalfonsi]

I am OK with this PR, @aalfonsi please generate an issue to address the random failures.

Is this #1676 enough? Or you want me to create another one?

[aalfonsi]

since everything is approved, is now mergeable? (Can anybody merge it? :D )

[wangcj05]

@Jimmy-INL Can you approve and merge it?

[Jimmy-INL]

I am OK, but please @aalfonsi generate an issue about random failures.

[mandd]

@wangcj05: are you ok if we merge this PR?

[wangcj05]

@mandd Yes, we can merge it.

All reviewers agree the changes, and This PR can be merged.

[wangcj05]

checklist is good, and PR can be merged.

[wangcj05]

@aalfonsi I have merged your PR, thanks for your contribution. @Jimmy-INL I'm sorry I need to dismiss your review in order to merge this PR.

[aalfonsi]

Thank you all!