Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in MAAP interface. #95

Closed
10 tasks done
joshua-cogliati-inl opened this issue Apr 7, 2017 · 1 comment
Closed
10 tasks done

Possible bug in MAAP interface. #95

joshua-cogliati-inl opened this issue Apr 7, 2017 · 1 comment

Comments

@joshua-cogliati-inl
Copy link
Contributor

joshua-cogliati-inl commented Apr 7, 2017

MAAP5Interface.py has the code:

if timer in lines[line]: found[cont]=True

Is it possible for this to give a false positive? (timer == "10", with the line "Time 100") (Not sure what the values look like so maybe this is impossible.)

From: https://hpcgitlab.inl.gov/idaholab/raven/issues/776


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or improvement?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest stable branch? If yes, is there any issue tagged with stable (create if needed)?
  • 5. If the issue is being closed without a merge request, has an explanation of why it is being closed been provided?
@alfoa
Copy link
Collaborator

alfoa commented Jan 24, 2020

Closing since no longer valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants