Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEFECT] Outstream error if not Dataobject found results in a crash #1514

Closed
10 tasks done
alfoa opened this issue Apr 15, 2021 · 1 comment · Fixed by #1503
Closed
10 tasks done

[DEFECT] Outstream error if not Dataobject found results in a crash #1514

alfoa opened this issue Apr 15, 2021 · 1 comment · Fixed by #1503

Comments

@alfoa
Copy link
Collaborator

alfoa commented Apr 15, 2021


Defect Description

Describe the defect

What did you expect to see happen?

The OutStreamInterface to error out with a meaningful error if a DataObject that was supposed to be in the step, was not inputted by the user.

What did you see instead?

A crash:
image001

Do you have a suggested fix for the development team?

Fix of the index that is not defined

Describe how to Reproduce
Steps to reproduce the behavior:
1.
2.
3.
4.

Screenshots and Input Files
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

Platform (please complete the following information):

  • OS: [e.g. iOS]
  • Version: [e.g. 22]
  • Dependencies Installation: [CONDA or PIP]

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@alfoa alfoa changed the title [DEFECT] Title Here [DEFECT] Outstream error if not Dataobject found results in a crash Apr 15, 2021
@alfoa alfoa mentioned this issue Apr 15, 2021
9 tasks
@Jimmy-INL
Copy link
Collaborator

Closure approved via PR # 1503, no email is required since the error results in a crash, not wrong results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants