Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singke Sample in Optimizer crashes run. #1002

Closed
10 tasks done
AaronEpiney opened this issue May 30, 2019 · 1 comment · Fixed by #1163
Closed
10 tasks done

Singke Sample in Optimizer crashes run. #1002

AaronEpiney opened this issue May 30, 2019 · 1 comment · Fixed by #1163

Comments

@AaronEpiney
Copy link
Collaborator

AaronEpiney commented May 30, 2019


Issue Description

What did you expect to see happen?

For testing, I take only one sample in the Optimizer.

What did you see instead?

It crashes with

  File "/home/epinas/project_HYBRID/hyb_update/raven/framework/Optimizers/GradientBasedOptimizer.py", line 215, in finalizeSampler
    value = self.counter['recentOptHist'][traj][0][self.objVar]
KeyError: 'NPV_mult'

Do you have a suggested fix for the development team?

Check for insufficient samples in FinalizeSampling.

Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@alfoa
Copy link
Collaborator

alfoa commented Mar 27, 2020

Closure checklist passed...

Closure approved via #1163 (New optimization class)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants