Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ask user confirmation when leaving a screen while songs are being added to playlist #48

Closed
icefields opened this issue Feb 15, 2024 · 1 comment
Closed

ask user confirmation when leaving a screen while songs are being added to playlist #48

icefields opened this issue Feb 15, 2024 · 1 comment
Assignees
@icefields
Labels
enhancement New feature or request

Comments

@icefields
Copy link
Owner

The legacy version of create/edit playlist is quite slow because it adds the songs one by one. If a user leaves the screen the process is stopped.
There is 2 possible fixes for this:

  • let a higher-scope view model handle this operation (right now PlaylistDetailViewModel)
  • warn the user with a dialog that leaving the current screen will cause the operation of editing playlist to stop.
@icefields icefields added the enhancement New feature or request label Feb 15, 2024
@icefields icefields self-assigned this Feb 15, 2024
@icefields
Copy link
Owner Author

done in v0.18-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@icefields icefields

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@icefields