Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album Art Caching #126

Closed
dhiachou opened this issue Jun 3, 2024 · 3 comments
Closed

Album Art Caching #126

dhiachou opened this issue Jun 3, 2024 · 3 comments

Comments

@dhiachou
Copy link

dhiachou commented Jun 3, 2024

Rendering album art is currently kind of slow (depending on internet speed + server responsiveness).

It would be nice to cache the album arts locally on the phone to avoid reloading them from the server every time we access an album or a song.

@icefields
Copy link
Owner

icefields commented Jun 4, 2024

hi,
album arts are already cached. I use both memory cache and disk cache. I reserve 5% of the app memory for image cache, which are also cached aggressively on disk, to be available in offline mode.

@icefields
Copy link
Owner

icefields commented Jun 4, 2024

I just tested the cache.

  • I verified that they are loaded in memory using the memory analizer in Android Studio.
  • I checked the subdirectory that I use for caching, I can see the images there.

As a last test I put the phone in airplane mode, and images still load (directly from cache with no network).

Here's a screenshot of the directory containing the cached images on my device after a fresh installation of the app.

image

@icefields
Copy link
Owner

I'm going to close this ticket. Feel free to reopen it if you find evidence that your cache is not working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants