From 34f7fdf65e94514b34e76fe880aaa13c642cdf22 Mon Sep 17 00:00:00 2001 From: David Blum Date: Thu, 25 Jan 2024 15:39:55 -0800 Subject: [PATCH 1/3] Fix typo --- docs/design/source/testcasedev.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/design/source/testcasedev.rst b/docs/design/source/testcasedev.rst index a6961176d..20999967d 100755 --- a/docs/design/source/testcasedev.rst +++ b/docs/design/source/testcasedev.rst @@ -146,7 +146,7 @@ The second function is to export a wrapper FMU that utilizes the signal exchange 4. Add one output for every Read block found named :code:`_y`. Assign :code:`_y` the unit, descriptions, min/max, and other signal attribute data specified by the Read block. -5. For Overwrite blocks, connect :code:`_u` to :code:`.u`, :code:`_activate` to :code:`.activate`, and :code:`_y` to :code:`.y`. +5. For Overwrite blocks, connect :code:`_u` to :code:`.uExt.y`, :code:`_activate` to :code:`.activate.y`, and :code:`_y` to :code:`.y`. 6. For Read blocks, connect :code:`_y` to :code:`.y`. From 9db3b35a082614b79a1311b1c65aed1182d07f2b Mon Sep 17 00:00:00 2001 From: David Blum Date: Thu, 25 Jan 2024 15:41:33 -0800 Subject: [PATCH 2/3] Update release notes --- releasenotes.md | 1 + 1 file changed, 1 insertion(+) diff --git a/releasenotes.md b/releasenotes.md index 0312ed2ca..70e8e291f 100644 --- a/releasenotes.md +++ b/releasenotes.md @@ -11,6 +11,7 @@ Released on xx/xx/xxxx. - Specify the Python version (3.7) used for building the wrapper to execute the example JavaScript controllers in the unit test. This is for [#594](https://github.com/ibpsa/project1-boptest/issues/594). - Allow simulations and forecast to work across the end of the year to the next year. This is for [#239](https://github.com/ibpsa/project1-boptest/issues/239). - Pin base Docker image to ``linux/x86_64`` platform. This is for [#608](https://github.com/ibpsa/project1-boptest/issues/608). +- Correct typo in design documentation about connecting inputs to overwrite blocks in wrapper model. This is for [#601](https://github.com/ibpsa/project1-boptest/issues/601). ## BOPTEST v0.5.0 From 494bc9fe8d13eea918b1bf2da3cf3545304fd088 Mon Sep 17 00:00:00 2001 From: David Blum Date: Fri, 26 Jan 2024 08:14:10 -0800 Subject: [PATCH 3/3] Update data= to json= in some tests --- testing/utilities.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/testing/utilities.py b/testing/utilities.py index 881f18ff3..ffe765bcf 100644 --- a/testing/utilities.py +++ b/testing/utilities.py @@ -749,35 +749,35 @@ def test_invalid_forecast_parameters(self): 'horizon': 'foo', 'interval': 300} payload = requests.put('{0}/forecast'.format(self.url), - data=forecast_parameters_ref) + json=forecast_parameters_ref) self.compare_error_code(payload, "Invalid non-numeric horizon in forecast request did not return 400 message.") # Try setting non-numeric interval forecast_parameters_ref = {'point_names':forecast_points, 'horizon': 3600, 'interval': 'foo'} payload = requests.put('{0}/forecast'.format(self.url), - data=forecast_parameters_ref) + json=forecast_parameters_ref) self.compare_error_code(payload, "Invalid non-numeric interval in forecast request did not return 400 message.") # Try setting negative horizon forecast_parameters_ref = {'point_names':forecast_points, 'horizon': -3600, 'interval': 300} payload = requests.put('{0}/forecast'.format(self.url), - data=forecast_parameters_ref) + json=forecast_parameters_ref) self.compare_error_code(payload, "Invalid negative horizon in forecast request did not return 400 message.") # Try setting negative interval forecast_parameters_ref = {'point_names':forecast_points, 'horizon': 3600, 'interval': -300} payload = requests.put('{0}/forecast'.format(self.url), - data=forecast_parameters_ref) + json=forecast_parameters_ref) self.compare_error_code(payload, "Invalid negative interval in forecast request did not return 400 message.") # Try setting invalid point name forecast_parameters_ref = {'point_names':['foo'], 'horizon': 3600, 'interval': 300} payload = requests.put('{0}/forecast'.format(self.url), - data=forecast_parameters_ref) + json=forecast_parameters_ref) self.compare_error_code(payload, "Invalid point_names in forecast request did not return 400 message.") def test_invalid_scenario(self):