Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Data_Generator.generate_setpoints #368

Closed
dhblum opened this issue Oct 11, 2021 · 1 comment
Closed

Fix Data_Generator.generate_setpoints #368

dhblum opened this issue Oct 11, 2021 · 1 comment

Comments

@dhblum
Copy link
Collaborator

dhblum commented Oct 11, 2021

This issue is to fix Lines 466 and 468 of data/data_generator.py so that the correct occupied and unoccupied set points are used when generating set point data for resource csvs. A quick check reveals that none of the current test cases utilize this functionality. The coming single_zone_commercial hydronic in #160 utilizes it, but that set point data needs to be changed anyway to using model data to consider weekends.

So this is mainly precautionary for future use cases to just get it right.

@dhblum
Copy link
Collaborator Author

dhblum commented Oct 21, 2021

Closed by #370.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant