Show difference in hours

[ibLeDy]

We can show what the hour difference is, maybe where we show the --zone.

• It can be just a number, but I think we should use gmt+
• We can use an argument like --difference

[26tanishabanik]

@ibLeDy I would like to take up this issue, kindly assign it to me

[26tanishabanik]

You are 10.5 hrs ahead of Mexico_City
You are 9.5 hrs ahead of New_York

Will the above statement work?

[26tanishabanik]

I made a pull request #28 , but its failing the checks, because some modules are not installing, though I have included them in the requirements-dev.txt

[ibLeDy]

You are 10.5 hrs ahead of Mexico_City You are 9.5 hrs ahead of New_York

Will the above statement work?

Hmm this feature is supposed to work like --zone, adding information to the output table (maybe in the header, or on the current hour, or somewhere where it fits)

[26tanishabanik]

You are 10.5 hrs ahead of Mexico_City You are 9.5 hrs ahead of New_York
Will the above statement work?

Hmm this feature is supposed to work like --zone, adding information to the output table (maybe in the header, or on the current hour, or somewhere where it fits)
But the tzlocal module is not installing in the test

[26tanishabanik]

Only that module is failing, but the module is available for python>=3.6, can you kindly look into it?

[26tanishabanik]

You are 10.5 hrs ahead of Mexico_City You are 9.5 hrs ahead of New_York
Will the above statement work?

Hmm this feature is supposed to work like --zone, adding information to the output table (maybe in the header, or on the current hour, or somewhere where it fits)

Can it be added like, headers timezone name and ahead or behind column header?

[ibLeDy]

I made a pull request #28 , but its failing the checks, because some modules are not installing, though I have included them in the requirements-dev.txt

I will have to take a closer look, but I think it is not necessary to add a new dependency (and I also would like to avoid it if possible), as we already have all the hour info, so we just need a timedelta of some sorts to make the calculation inside ' _build_table`, for example.

[26tanishabanik]

I made a pull request #28 , but its failing the checks, because some modules are not installing, though I have included them in the requirements-dev.txt

I will have to take a closer look, but I think it is not necessary to add a new dependency (and I also would like to avoid it if possible), as we already have all the hour info, so we just need a timedelta of some sorts to make the calculation inside ' _build_table`, for example.

Yah, I tried that, it gives 00:00

[26tanishabanik]

I made a pull request #28 , but its failing the checks, because some modules are not installing, though I have included them in the requirements-dev.txt

I will have to take a closer look, but I think it is not necessary to add a new dependency (and I also would like to avoid it if possible), as we already have all the hour info, so we just need a timedelta of some sorts to make the calculation inside ' _build_table`, for example.

But I am giving it a try again

[ibLeDy]

It could be addded in the header where the timezone is displayed, to the right, but if the --zone argument is provided, the order sould be <timezone> <zone> <difference>.

I don't have time right now to create a POC but should be possible. Yes, please, try again.

[26tanishabanik]

Its done

[26tanishabanik]

Will this do?

[ibLeDy]

I would prefer if the difference would be added to the existing columns, not in new ones, and we only need the hour difference. And it should not be added to the LOCAL header.

Also, seems like you only used the --zone argument, and this feature is separate from that one, so it would be activated when using --difference. I will left some examples below showing how it would look using the different arguments.

timezone-converter tijuana --difference

timezone-converter tijuana --difference --zone

[26tanishabanik]

The feature is done

[26tanishabanik]

[26tanishabanik]

@ibLeDy Can you kindly review the PR?

[ibLeDy]

I didn't had time today but hopefully tomorrow I will be available to do it.

[ibLeDy]

I left a review in the PR, there are still some changes that we need to do :)

[ibLeDy]

Hello, @26tanishabanik. Are you still working on this?