Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e-82C to e-837 are broken - they are multi-codepoint sequences #1

Closed
iamcal opened this issue Mar 28, 2011 · 1 comment
Closed

e-82C to e-837 are broken - they are multi-codepoint sequences #1

iamcal opened this issue Mar 28, 2011 · 1 comment

Comments

@iamcal
Copy link
Owner

iamcal commented Mar 28, 2011

From an email conversation with 杜志刚:

On 3/27/2011 9:23 PM, 杜志刚 wrote:

Please see
https://www.unicode.org/~scherer/emoji4unicode/snapshot/full.html#e-82C (e-82C
~ e-837)
There are BAD multiple code points :

|| num   ||chr|| first       || second   ||
|| e-82C || # || U+0023  || U+20E3 ||
|| e-82E || 1 || U+0031  || U+20E3 ||
|| e-82F || 2 || U+0032  || U+20E3 ||
...
|| e-837 || 0 || U+0030  || U+20E3 ||

The second code is BAD !

Ahhh! Now I understand what's happening here. U+20E3 is 'COMBINING ENCLOSING KEYCAP' and it draws a box around the character that comes before it, so the sequence "U+0032 U+20E3" displays a '2' in a square box, which is what we want. I think I want to modify the parser to use the sequence of 2 unicode codepoints instead of just one or the other.

The problem with using the first one is that it replaces characters where you don't expect it to - it will replace any numbers in text with the numbers-in-boxes emoji, which is almost never what you want (and the reason I changed it to begin with).

--cal

@iamcal
Copy link
Owner Author

iamcal commented Jul 29, 2011

this was patched on March 28, 2011 - forgot to close it i guess

@iamcal iamcal closed this as completed Jul 29, 2011
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant