Fix hsv to rgb #17
Open
Fix hsv to rgb #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make double round ( 1 decimals then 0 decimals ) to overcome lost of precision, see added unit test:
ex. r=0.49999999999999956 would round (r * 255) to 127 instead of expected 128
Note: other cases could require same approach, I only fixed this one.
Note : while library netstandard2.0 its ok, Test and demo frameworks are upgraded from from netcoreapp3.1 to net7 because out of support and generates follow error on unix platforms: