Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splitted ltm- and stm-memory roots for FileHandler to avoid tmp-clear… #564

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

Lukas113
Copy link
Collaborator

Split long-term-memory disk-cache root from short-term-memory. The reason for this change is because before a differentiation between the two use-cases regarding the root-directory was not possible. Therefore, the default root-dir /tmp caused to remove long-term-memory files at each restart, which is not desired.

@Lukas113 Lukas113 requested a review from mpluess March 27, 2024 15:35
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 63.88889% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 66.93%. Comparing base (d423934) to head (d32d23c).

Files Patch % Lines
karabo/util/file_handler.py 63.88% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
+ Coverage   66.88%   66.93%   +0.04%     
==========================================
  Files          49       49              
  Lines        4980     4996      +16     
==========================================
+ Hits         3331     3344      +13     
- Misses       1649     1652       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mpluess mpluess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lukas113 Lukas113 merged commit 17b74a7 into main Mar 28, 2024
3 checks passed
@Lukas113 Lukas113 deleted the xdg-base-dir branch March 28, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants