Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regarding fix #273 - new error raise - "EDS map from recent .emd file: Element selection missing from the metadata" #279

Open
OliDG opened this issue Jun 18, 2024 · 2 comments
Labels
type: bug Something isn't working

Comments

@OliDG
Copy link

OliDG commented Jun 18, 2024

Describe the bug

I commented on the closed case but realized it may stay unseen.
@ericpre @jlaehne
Thanks for the fix, I have tested it and it mostly works. There is an error generated (maybe there previously?) when no elements were selected for quantification before saving the .emd file from Velox ("elementSelection" key doesn't exist then).

ERROR | Hyperspy | If this file format is supported, please report this error to the HyperSpy developers. (hyperspy.io:600)
caught <class 'AttributeError'>: 'DictionaryTreeBrowser' object has no attribute 'elementSelection'

\Olivier

@OliDG OliDG added the type: bug Something isn't working label Jun 18, 2024
@ericpre
Copy link
Member

ericpre commented Jun 18, 2024

From reading the recent code changes, it is unlikely that this is a regression. Can you provide a file to reproduce this issue so that it can be added to the test suite? Smallest file possible please?
See https://hyperspy.org/rosettasciio/contributing.html#making-test-data-files for more information on making test file.

@OliDG
Copy link
Author

OliDG commented Jun 19, 2024

SI_empty selection.zip
Thanks for the reference! here is a test file just for you :)

\Olivier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants