Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigating security issues of jsonpickle #1672

Open
kukgini opened this issue Jun 13, 2024 · 0 comments
Open

Mitigating security issues of jsonpickle #1672

kukgini opened this issue Jun 13, 2024 · 0 comments

Comments

@kukgini
Copy link

kukgini commented Jun 13, 2024

A security guy told me about indy-node vulnerabilities. It's about jsonpickle security issue. And it is classified as critical. GHSA-j66q-qmrc-89rx

However the jsonpickle team defended that it is intended. And they suggested that to be sure to be safe, user of this library should set safe=True in calling jsonpickle.decode()
jsonpickle/jsonpickle#335

It appears that in indy-plenum, jsonpickle.decode() is called without safe parameter. Wouldn't it be better to add it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant