LegacyPeerDIDResolver: erroneously assigning same ID to multiple services

[dbluhm]

This appears to be the underlying issue to both:

• Upgrade IDIM Issuers to ACA-Py v0.10.2 and Askar only images. bcgov/DITP-DevOps#109
• Ledger writes not happening when an Endorser connection exists and issuer upgraded to 0.10.1 #2474

The LegacyPeerDIDResolver is assigning the same ID to multiple services (converted from IndyAgent services). This results in resolved DID Docs like the following:

{
  "did_document": {
    "@context": "https://w3id.org/did/v1",
    "id": "did:sov:4wvr7DC2XUtsHbpUpYaKvM",
    "authentication": [
      "did:sov:4wvr7DC2XUtsHbpUpYaKvM#1"
    ],
    "service": [
      {
        "id": "did:sov:4wvr7DC2XUtsHbpUpYaKvM#didcomm",
        "type": "did-communication",
        "priority": 0,
        "recipientKeys": [
          "did:sov:4wvr7DC2XUtsHbpUpYaKvM#1"
        ],
        "serviceEndpoint": "https://aries-endorser-agent-dev.apps.silver.devops.gov.bc.ca"
      },
      {
        "id": "did:sov:4wvr7DC2XUtsHbpUpYaKvM#didcomm",
        "type": "did-communication",
        "priority": 0,
        "recipientKeys": [
          "did:sov:4wvr7DC2XUtsHbpUpYaKvM#1"
        ],
        "serviceEndpoint": "wss:https://aries-endorser-agent-dev.apps.silver.devops.gov.bc.ca"
      }
    ],
    "verificationMethod": [
      {
        "id": "did:sov:4wvr7DC2XUtsHbpUpYaKvM#1",
        "type": "Ed25519VerificationKey2018",
        "controller": "did:sov:4wvr7DC2XUtsHbpUpYaKvM",
        "publicKeyBase58": "39msujHp1jPTPbWA5Ry9BnwGvbVw8WYGh8WYjoEryyQp"
      }
    ]
  },
  "metadata": {
    "resolver_type": "native",
    "resolver": "LegacyPeerDIDResolver",
    "retrieved_time": "2023-09-07T12:53:06Z",
    "duration": 42
  }
}

The corrections should be assigning unique IDs to the two services in this example.

This will require a patch release to be pushed out. This will be the first release after the Poetry conversion. We should get #2471 merged in support of this release as well.

@swcurran @WadeBarnes @usingtechnology

[swcurran]

@dbluhm — given the AATH issue we currently have (which may be nothing, but is annoying and unsolved…), should we do a patch release of this as 0.10.2, without the Poetry change? Or is it not worth it?

[dbluhm]

It wouldn't be too bad; I can probably cherry-pick the commit from #2476 over onto 0.10.1 tag without incident. Are there any challenges with doing a release from a branch rather than main?

[swcurran]

No — we’ve done it before. Easy to do.

[dbluhm]

I'll prepare a branch off of 0.10.1 with the cherry picked changes 👍

[dbluhm]

Pushed to: https://github.com/hyperledger/aries-cloudagent-python/tree/0.10.2

I haven't done anything but branch and cherry-pick so the publishing workflow will still be needed. Let me know if there's anything I can do to help with that process -- otherwise I'll assume you guys (BC Gov team) have it in hand 😄

[swcurran]

@usingtechnology @Jsyro — can you please review this? Is it likely to fix the issue that we are seeing with the IDIM issuer is the big concern.