Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/CD basic implementation based on GitHub Actions (#167) issue #168

Closed
bvernoux opened this issue Apr 8, 2024 · 3 comments · Fixed by #169
Closed

CI/CD basic implementation based on GitHub Actions (#167) issue #168

bvernoux opened this issue Apr 8, 2024 · 3 comments · Fixed by #169

Comments

@bvernoux
Copy link
Member

bvernoux commented Apr 8, 2024

Todo fix the CI/CD error
https://github.com/hydrabus/hydrafw/actions/runs/8603212358/job/23574579221
@bvernoux bvernoux mentioned this issue Apr 8, 2024
Merged
@ia
Copy link
Contributor

ia commented Apr 9, 2024

I'm already looking into this. My apologies for this. Just when I started to think that I'm aware of most nuances of GitHub Actions, it never stops prove me wrong. I will try to fix it as soon as I can. So you can freely assign this one to me.

@ia ia mentioned this issue Apr 9, 2024
Merged
@ia
Copy link
Contributor

ia commented Apr 9, 2024

I hope this one should fix it. Pardon for not responding faster. But I guess since there were no any per-commit builds before at all, it's not so bad after all.

@Baldanos
Copy link
Collaborator

Just merged the PR and it seems to be working fine now.

Thanks for the fix and following up on this feature ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

push.yml/env.sh: set helper variable to indicate building on github explicitly ia/hydrafw
3 participants
@ia @bvernoux @Baldanos