Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create_token id -> token_id breaks backwards compatibility #380

Open
jamesdmorgan opened this issue Jan 10, 2019 · 0 comments
Open

create_token id -> token_id breaks backwards compatibility #380

jamesdmorgan opened this issue Jan 10, 2019 · 0 comments
Labels
documentation documentation updates and/or requests for expanded documentation token Related to the token auth method
Projects
Bug / Feature Request Triage

Comments

@jamesdmorgan
Copy link

Hi

Moving from v0.2.17 to v0.3.0 the id param to create_token was changed to token_id (which does make more sense)

This broke backwards compatibility so may be worth retrospectively adding to the changelog for v0.3.0.

Thanks

James
@jeffwecan jeffwecan added this to Needs triage in Bug / Feature Request Triage via automation Jan 18, 2019
@jeffwecan jeffwecan added documentation documentation updates and/or requests for expanded documentation token Related to the token auth method labels Jan 18, 2019
@jeffwecan jeffwecan added this to the 0.7.3 milestone Jan 18, 2019
@jeffwecan jeffwecan moved this from Needs triage to Low priority in Bug / Feature Request Triage Jan 18, 2019
@jeffwecan jeffwecan modified the milestones: 0.8.0, 0.8.1 Mar 29, 2019
@jeffwecan jeffwecan modified the milestones: 0.8.3, 0.8.4 May 18, 2019
@jeffwecan jeffwecan modified the milestones: 0.9.1, 0.9.2 May 25, 2019
@jeffwecan jeffwecan removed this from the 0.9.2 milestone Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation documentation updates and/or requests for expanded documentation token Related to the token auth method
Projects
Bug / Feature Request Triage
  
Low priority
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffwecan @jamesdmorgan