Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity Engine lookup_group() Method Raises Exceptions When No Groups Found #329

Closed
jeffwecan opened this issue Nov 1, 2018 · 0 comments
Labels
identity Identity secrets engine; identity management solution for Vault secrets engines generally related to a Vault secrets engine
Milestone

Comments

@jeffwecan
Copy link
Member

jeffwecan commented Nov 1, 2018

Vault Version: 0.11.1
hvac Version: 0.7.0

  File "/usr/local/lib/python2.7/dist-packages/hvac/api/secrets_engines/identity.py", line 1031, in lookup_group
    return response.json()
  File "/usr/local/lib/python2.7/dist-packages/requests/models.py", line 897, in json
    return complexjson.loads(self.text, **kwargs)
  File "/usr/lib/python2.7/json/__init__.py", line 339, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python2.7/json/decoder.py", line 364, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python2.7/json/decoder.py", line 382, in raw_decode
    raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded

Would probably make more sense to return a None in these cases?

@jeffwecan jeffwecan added secrets engines generally related to a Vault secrets engine identity Identity secrets engine; identity management solution for Vault labels Nov 1, 2018
@jeffwecan jeffwecan added this to the 0.7.1 milestone Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
identity Identity secrets engine; identity management solution for Vault secrets engines generally related to a Vault secrets engine
Projects
None yet
Development

No branches or pull requests

1 participant