Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starting connection log should be debug level #25

Closed
eedgar opened this issue Oct 9, 2015 · 2 comments
Closed

starting connection log should be debug level #25

eedgar opened this issue Oct 9, 2015 · 2 comments

Comments

@eedgar
Copy link

eedgar commented Oct 9, 2015

[INFO ] Starting new HTTP connection (1): localhost

this should be debug level. I am using this in another application and it is logging this every time it connects cluttering the output.

@eedgar
Copy link
Author

eedgar commented Oct 9, 2015

import logging

Suppress the requests module logging.

requests_log = logging.getLogger("requests.packages.urllib3")
requests_log.setLevel(logging.WARNING)

@ianunruh
Copy link
Member

ianunruh commented Oct 9, 2015

So, it's generally a bad practice for a library to override the logging for another (dependent) library. That should be left up to the application to decide what logging is important and unimportant.

@ianunruh ianunruh closed this as completed Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants