Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for revoke-self endpoint. #23

Closed
jplabit opened this issue Sep 30, 2015 · 1 comment
Closed

Add support for revoke-self endpoint. #23

jplabit opened this issue Sep 30, 2015 · 1 comment
Labels
enhancement a new feature or addition

Comments

@jplabit
Copy link

jplabit commented Sep 30, 2015

I'm not sure how you would like this handled, or if you accept pull requests. Figured I would open an issue. Please let me know how you would like this handled going forward. :)

Vault 0.3.0 introduced the capability to revoke your own authentication token as a cleanup step. Reference https://vaultproject.io/docs/http/sys-revoke-self.html

I would like this capability added (maybe a revoke_self_token method?), and also think it would be useful to have an optional parameter to logout to revoke the token. Maybe something like logout(revoke_token=False) by default to not change functionality, but revoke_token=True would call revoke_self_token() before setting self.token = None.

Thanks for putting together this library. Very useful!

@ianunruh ianunruh added the enhancement a new feature or addition label Oct 6, 2015
@ianunruh
Copy link
Member

ianunruh commented Oct 8, 2015

Thanks for reporting this issue. I've added support in 109d721

@ianunruh ianunruh closed this as completed Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement a new feature or addition
Projects
None yet
Development

No branches or pull requests

2 participants