feat: Raft Autopilot endpoints #1176
Open
+161
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantist
added
enhancement
|
thanks @kayra1 and welcome! It'll take me a little time to review this more closely. In the meantime, take a look at the lint/test runs in CI, consider running linting, formatting, and tests locally to enable more rapid iteration so you don't have to wait for CI (I have to approve each new push for first time contributors). cc @tot19 since I think you were interested as well |
|
will do, thanks |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
==========================================
- Coverage 87.56% 87.38% -0.18%
==========================================
Files 67 67
Lines 3288 3298 +10
==========================================
+ Hits 2879 2882 +3
- Misses 409 416 +7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1165
This adds 3 endpoints from the autopilot feature of Vault as described in the issue #1165 .
I locally validated and wrote tests for these functions, but I added a skip reason stating that the integration tests currently only support Consul. I am not too familiar with the testing setup in this repo, but let me know if there is anything I can address there.
Thanks.