Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transit key types outdated #1135

Open
calnighters opened this issue Feb 15, 2024 · 1 comment
Open

Transit key types outdated #1135

calnighters opened this issue Feb 15, 2024 · 1 comment
Labels
enhancement a new feature or addition help wanted Contributions welcome! secrets engines generally related to a Vault secrets engine transit Transit secrets engine

Comments

@calnighters
Copy link

The current supported transit key types are outdated in comparison to the types vault offers.
Current in hvac:

hvac/hvac/constants/transit.py

Line 6 in 2a68a56

ALLOWED_KEY_TYPES = [

Current supported: https://developer.hashicorp.com/vault/api-docs/secret/transit#type

Could the list be updated to bring in line with what vault offers please.
@briantist briantist added enhancement a new feature or addition secrets engines generally related to a Vault secrets engine transit Transit secrets engine help wanted Contributions welcome! labels Apr 15, 2024
@briantist
Copy link
Contributor

Thank you for opening this @calnighters , It seems like a straightforward change, if you're interested in opening a PR for it that would be very helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement a new feature or addition help wanted Contributions welcome! secrets engines generally related to a Vault secrets engine transit Transit secrets engine
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@briantist @calnighters