From 2ba70d4514abe65896a2505cd41320874d633427 Mon Sep 17 00:00:00 2001
From: hugo pendlebury <hugo.pendlebury@gmail.com>
Date: Wed, 31 Jan 2024 20:53:45 +0000
Subject: [PATCH] validation

---
 src/gribreader.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gribreader.cpp b/src/gribreader.cpp
index f0051ea..87bdb18 100644
--- a/src/gribreader.cpp
+++ b/src/gribreader.cpp
@@ -114,7 +114,6 @@ enum conversionDataTypes {
 
 GribReader GribReader::withConversions(std::string conversionsPath) {
     cout << "Reading conversions CSV" << endl;
-    //TODO add validation of the column names
 
     std::unordered_map<std::string, std::shared_ptr<arrow::DataType>> fieldTypes;
     fieldTypes.emplace(make_pair("parameterId", arrow::int64()));
@@ -129,6 +128,7 @@ GribReader GribReader::withConversions(std::string conversionsPath) {
     convertOptions.column_types = fieldTypes;
 
     std::shared_ptr<arrow::Table> conversions = getTableFromCsv(conversionsPath, convertOptions);
+    validateConversionFields(conversions, " passed conversions via arrow");
     withConversions(conversions);
     return *this;
 }