Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enforced defaultColor #85

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Fix enforced defaultColor #85

merged 1 commit into from
Jul 26, 2023

Conversation

kusyka911
Copy link
Contributor

@kusyka911 kusyka911 commented Jul 18, 2023 •
edited
Loading

What problem does this PR solve?

should solve #50
and allow to enforce default theme to dark by site developer in no-script browsers.

Is this PR adding a new feature?

no

Is this PR related to any issue or discussion?

issue #50

PR Checklist

  • I have verified that the code works as described/as intended.
  • This change adds a social icon which has a permissive license to use it.
  • This change does not include any external library/resources.
  • This change does not include any unrelated scripts (e.g. bash and python scripts).
  • I have enabled maintainer edits for this PR.

@netlify
Copy link

netlify bot commented Jul 18, 2023 •
edited
Loading

✅ Deploy Preview for hugo-blog-awesome ready!

Name Link
🔨 Latest commit a412473
🔍 Latest deploy log https://app.netlify.com/sites/hugo-blog-awesome/deploys/64b6f27c9e7ea7000857caa2
😎 Deploy Preview https://deploy-preview-85--hugo-blog-awesome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kusyka911 kusyka911 mentioned this pull request Jul 18, 2023
Closed
@kusyka911 kusyka911 force-pushed the bug/default-dark-mode-noscript branch from 0977179 to 85cca10 Compare July 18, 2023 20:10
@github-actions github-actions bot added size/xl and removed size/xs labels Jul 18, 2023
@github-actions
Copy link

This PR exceeds the recommended size of 300 lines (counting both additions & deletions). Kindly ensure that you are NOT addressing multiple issues in one PR. We recommend you to create atomic PRs which focus on a single change.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 18, 2023
View reviewed changes
assets/js/sw.js Fixed Show fixed Hide fixed
@kusyka911 kusyka911 force-pushed the bug/default-dark-mode-noscript branch 2 times, most recently from 0977179 to ec2634c Compare July 18, 2023 20:11
@github-actions
Copy link

This PR exceeds the recommended size of 300 lines (counting both additions & deletions). Kindly ensure that you are NOT addressing multiple issues in one PR. We recommend you to create atomic PRs which focus on a single change.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 18, 2023
View reviewed changes
assets/js/sw.js Fixed Show fixed Hide fixed
@kusyka911 kusyka911 force-pushed the bug/default-dark-mode-noscript branch from ec2634c to a412473 Compare July 18, 2023 20:13
@github-actions github-actions bot added size/xs and removed size/xl labels Jul 18, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

hugo-sid
hugo-sid approved these changes Jul 26, 2023
View reviewed changes
Copy link
Owner

@hugo-sid hugo-sid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kusyka911, for fixing the default color mode issue (#50).

@hugo-sid hugo-sid merged commit 970bdd9 into hugo-sid:main Jul 26, 2023
9 checks passed
@hugo-sid hugo-sid mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugo-sid hugo-sid hugo-sid approved these changes

Assignees
No one assigned
Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kusyka911 @hugo-sid