Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image and Emoji support + "Link 1" issue #4

Closed
paddy-exe opened this issue Mar 11, 2023 · 10 comments
Closed

Image and Emoji support + "Link 1" issue #4

paddy-exe opened this issue Mar 11, 2023 · 10 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@paddy-exe
Copy link

paddy-exe commented Mar 11, 2023

Hey there, I have been using your template for my blog website: https://paddy-exe.github.io

Thank you for creating this :D

I have found several issues:

  1. enableEmoji: true in the md header does NOT actually activate Emoji support. Not really sure why
  2. I have no idea where I can put images to embed into the .md files. I have tried static, a post package folder with an img subfolder and none worked
  3. In the template, there is no way to change the "Link 1" and "Link 2" links except to go into the template itself and change it. Is this intended?
@hugo-sid
Copy link
Owner

hugo-sid commented Mar 11, 2023

Hi Patrick.

I have been using your template for my blog website: https://paddy-exe.github.io/

I'm glad to know that my theme has been useful to you. Thanks for choosing this theme.

Thank you for creating this :D

You're welcome Patrick.

I have found several issues

Thanks for identifying these issues. Here is what I have to say as of now:

  1. Emoji issue - I am able to reproduce this. I will implement a fix.
  2. Putting images - I have not yet used images in the example or sample posts (in the exampleSite folder). I will update you when I do this.
  3. No way to change the links except to go into the template - no Patrick, it's not intended to be that way. I will implement a more elegant solution where links can be managed in the config.toml file.

@paddy-exe
Copy link
Author

  1. Emoji issue - I am able to reproduce this. will implement a fix.
  2. Putting images - I have not yet used images in the example or sample posts (in the exampleSite folder. I will update you when I do this.
  3. No way to change the links except to go into the template - no Patrick, it's not intended to be that way. I will implement a more elegant solution where links can be managed in the config.toml file.

Thanks for the quick reply! Looking forward to the fixes!

@hugo-sid hugo-sid added bug Something isn't working enhancement New feature or request labels Mar 11, 2023
@hugo-sid
Copy link
Owner

hugo-sid commented Mar 13, 2023

  • Emoji issue
  • Image usage illustration
  • Better way to manage footer links

@hugo-sid
Copy link
Owner

hugo-sid commented Mar 13, 2023

Hi Patrick.

  1. The emoji issue has been solved.

  2. The links in the footer can now be managed using config.toml.

    Here is a sample configuration:

    [[params.socialIcons]]
    name = "github"
    url = "https://github.com/hugo-sid"
    [[params.socialIcons]]
    name = "twitter"
    url = "https://twitter.com"
    [[params.socialIcons]]
    name = "Rss"
    url = "index.xml"

    You can see the result of this below.

    image

    I feel, this is an elegant solution to manage links in the footer. What do you say ?

@paddy-exe
Copy link
Author

paddy-exe commented Mar 13, 2023

Hi Patrick.

  1. The emoji issue has been solved.
  2. The links in the footer can now be managed using config.toml.
    Here is a sample configuration:
    I feel, this is an elegant solution to manage links in the footer. What do you say ?

This is a very elegant solution! Thank you :D Btw where does this retrieve the icons from? Would be good to refer to the source of the icons (if they are not made by you) so ppl can check if another name like e.g. Mastodon or Ko-Fi is supported

Never mind, I found it out xD

@hugo-sid
Copy link
Owner

hugo-sid commented Mar 14, 2023

This is a very elegant solution! Thank you :D

You are welcome Patrick.

You are correct regarding names of icons. How does someone figure out the icons that they can use ?
I made it clear by adding documentation here.

@hugo-sid
Copy link
Owner

hugo-sid commented Mar 14, 2023

I have modified the exampleSite/content folder to make it more suitable to include images. You can check it out in this post.

@paddy-exe
Copy link
Author

paddy-exe commented Mar 14, 2023

I have modified the exampleSite/content folder to make it more suitable to include images. You can check it out in this post.

Amazing work! Thank you very much :D I assume this also means that gifs are also supported? Also, do the files inside the folders have to be named index.md or is that irrelevant?

@hugo-sid
Copy link
Owner

hugo-sid commented Mar 15, 2023

Amazing work! Thank you very much :D

You are welcome Patrick. Thanks for pointing out the issues.

I assume this also means that gifs are also supported?

Yes, you are correct.

Also, do the files inside the folders have to be named index.md or is that irrelevant?

The markdown file has to be named index.md. For more information you can read about leaf bundles on the Hugo documentation website here. There is no restriction on naming of other files or resources.

@paddy-exe
Copy link
Author

Perfect. Since all the issues are solved now, I will close this issue here now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Development

No branches or pull requests

2 participants