Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] 使用外部图床时，无法根据标题索引正确转跳至文章指定位置 #348

Closed
For-December opened this issue Jul 25, 2023 · 5 comments · Fixed by #362
Closed

[BUG] 使用外部图床时，无法根据标题索引正确转跳至文章指定位置 #348

For-December opened this issue Jul 25, 2023 · 5 comments · Fixed by #362
Assignees
@Lruihao
Labels
bug Something isn't working tested Processing completion test passed
Milestone
v0.2.18-lts

Comments

@For-December
Copy link

For-December commented Jul 25, 2023 •
edited
Loading

Describe the bug 描述你遇到的错误

如题，当我使用了其他域的图床时，无论是通过 URL 最后一级，还是通过点击右侧的标题索引，在文章内跳转都会有偏差

Expected behavior 期待的行为

等大佬修复

Screenshots 屏幕截图

image

Build Environment 构建环境

hugo：0.115.4_extended
主题：FixIt 0.2.18

Preview Environment 预览环境

  • OS: [Windows 10]
  • Brower [Chrome, Edge]

Additional Information 补充信息

默认配置文件
@For-December For-December added the bug Something isn't working label Jul 25, 2023
@Lruihao Lruihao self-assigned this Jul 25, 2023
@Lruihao Lruihao added this to the v0.2.18 milestone Jul 25, 2023
@Lruihao Lruihao mentioned this issue Oct 25, 2023
Merged
@Lruihao
Copy link
Member

Lruihao commented Oct 26, 2023 •
edited
Loading

目前有两种解决办法：

  1. 使用 image shortcode 手动为图床图片设置宽高或 loading="eager"
  2. 开启 params.cacheRemoteImages 参数，详见 Add option to cache remote image locally #362

@Lruihao Lruihao added the testing Processing completed to be tested label Oct 26, 2023
@Lruihao

This comment was marked as outdated.

Sign in to view
@Lruihao Lruihao added tested Processing completion test passed and removed testing Processing completed to be tested labels Oct 27, 2023
@fengguowudi

This comment was marked as resolved.

Sign in to view
@Lruihao
Copy link
Member

Lruihao commented Oct 30, 2023 •
edited
Loading

原 LoveIt 希望支持多分辨率显示，并让浏览器计算出正在显示的显示器的分辨率（size="auto"），然后显示 srcset 引用的最适合的图片。所以在处理懒加载图片的大小时，应该保持和加载后的实际显示图片保持相同的处理逻辑。

参考：

Lruihao added a commit that referenced this issue Nov 1, 2023
@Lruihao
🐛 Fix: anchor jump exception caused by lazy loading of responsive ima…
de25a03 
…ges (#348)
Lruihao added a commit that referenced this issue Nov 1, 2023
@Lruihao
🐛 Fix: anchor jump exception caused by lazy loading of responsive ima…
c460693 
…ges (#348)
@Lruihao
Copy link
Member

Lruihao commented Nov 1, 2023

测试文章：https://fixit-nt2t6uxm7-cell-x.vercel.app/zh-cn/tests/markdown/

@Lruihao Lruihao closed this as completed in a631096 Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lruihao Lruihao

Labels
bug Something isn't working tested Processing completion test passed
Projects
Roadmap of FixIt
Archived in project
Milestone
v0.2.18-lts
Development

Successfully merging a pull request may close this issue.

Add option to cache remote image locally hugo-fixit/FixIt
3 participants
@Lruihao @fengguowudi @For-December