Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty list of splits on config-split-names #2803

Open
AndreaFrancis opened this issue May 14, 2024 · 1 comment
Open

Empty list of splits on config-split-names #2803

AndreaFrancis opened this issue May 14, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@AndreaFrancis
Copy link
Contributor

We have some entries with empty splits:

Atlas atlas-x5jgb3-shard-0 [primary] datasets_server_cache> db.cachedResponsesBlue.countDocuments({kind:"config-split-names", http_status:200, "content.splits":{ $exists: true, $size: 0}})
97

Note that the viewer for these datasets always shows: Error code: ConfigNotFound
Like https://huggingface.co/datasets/Vinay573/aarkoocustomdataset
image
But, when using the datasets library, it is possible to get the dataset split:
image
This issue is due because we first load splits from config-info and then from streaming, but if config-info is empty, it will store no splits.
Should we throw an error if the splits list is empty?

@AndreaFrancis AndreaFrancis added the bug Something isn't working label May 14, 2024
@severo
Copy link
Collaborator

severo commented May 15, 2024

Yes, sure, it does not make sense for the dataset viewer to process a dataset without splits. Better to raise an error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants