-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebSocket support #11
Comments
From what I've seen it should work, although we probably should have some tests for proof |
i would think it should work as well, but we have no tests in place for websockets. we are working out cranking out the new version, does anyone want to step up and do a simple vows websocket test? |
Maybe it should work, but according to my testing it does not (I just upgraded to 0.3.0, same result). The server behind the proxy never gets the websocket connection (I'm using socket.io here). |
i've been talking to the socket.io author and i think he's gonna help getting some vows tests for websockets / socket.io if you can create the tests for websockets we can make them pass. if not, rauchg should have something posted soon. |
looks like the fork @ https://github.com/donnerjack13589/node-http-proxy might be a fix for this. has unit tests as well. |
Is this merged yet? If so why not? |
looks like there has been some work on this, going to try to get these tests to pass https://github.com/nodejitsu/node-http-proxy/blob/master/test/node-http-proxy-test.js#L61 https://github.com/nodejitsu/node-http-proxy/blob/master/lib/node-http-proxy.js#L106 |
Fixed in b0b0183. Needs some more tests before I release v0.5.0, but in the meantime checkout the working demo here: https://github.com/nodejitsu/node-http-proxy/blob/v0.5.0/examples/web-socket-proxy.js |
[fix] add ability to proxy websockets over HTTPS
Is node-http-proxy supposed to support websockets? It seems that websocket are not passed through (according to my testing), is that correct or do I have to configure something differently?
The text was updated successfully, but these errors were encountered: