protocol option expects a colon

[javadoug]

My reverse proxy didn't like my requests because I needed to specify the protocol on the proxy config and include a colon on the end of the string. I wonder if the colon is over zealous code, a typo or really needed.

Error:
400 Bad Request
The plain HTTP request was sent to HTTPS port

https://github.com/nodejitsu/node-http-proxy/blob/e7d50b1a376035a50c82db38605e99feb30afd36/lib/http-proxy/common.js#L28

https://github.com/nodejitsu/node-http-proxy/blob/fcdbf46e4d1301ac78da05eeeac583339a5dc43a/lib/http-proxy/passes/ws-incoming.js#L87

Note: connect does NOT require a colon on the protocol option. The server will fail to start with a fatal error message stating invalid protocol.

The grunt-connect-proxy settings needed to make http-proxy work:

[jcrugzz]

@javadoug we expect to receive a full URL string or an object that has been parsed by url.parse(). This is why I just deal with URL strings when it comes to config as it simplifies it infinitely.

[javadoug]

@jcrugzz thanks for getting back. pls consider an alternative, perhaps, checking with regex /^https:?/.test(protocol). And if the code construct urls from the parts, the url class supports protocol with and without the colon.

[jcrugzz]

@javadoug I'd take a PR with a proper regex :). I'd export a protocol regex from common so it can be used in both places. Should be something like exports.protocolRegex = /^https|wss/. This also makes sure its precompiled.

[jcrugzz]

@javadoug implemented in 1.7.3

[javadoug]

thank you.

On Dec 8, 2014, at 11:05 PM, Jarrett Cruger [email protected] wrote:

@javadoug implemented in 1.7.3

—
Reply to this email directly or view it on GitHub.