DELETE request issued to nginx back-end fails with 411

[ian7]

Bug details can be found here: http:https://development.blog.saw.sonyx.net/2012/11/http-delete-failing-with-411.html

[mmalecki]

Interesting. I'll accept it, but please fix coding style:

if (req.method === 'DELETE') {
  req.headers['content-length'] = '0';
}

and make sure that indentation matches rest of the code. Thanks!

[ian7]

Done. let me know if this is ok.

• M.

On Thu, Nov 22, 2012 at 8:36 PM, Maciej Małecki [email protected]:

Interesting. I'll accept it, but please fix coding style:

if (req.method === 'DELETE') {
req.headers['content-length'] = '0';
}

and make sure that indentation matches rest of the code. Thanks!

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/338#issuecomment-10643388.

[indexzero]

Reluctantly +1

[rc1]

In my case, as an observation, nginx is stripping the header's 'content-length'. When I run locally 'content-length' exists on the req and when I run remotely heroku 'content-length' is stripped from the req. The easy fix for me was to just add it back to the req before passing to node-http-proxy.

[andreareginato]

Similar problem for CORS features. When the browser makes the preflight requestI get a 411 error. As far as the preflight is automatically made from the browser there is no way to set content-length to 0 and CORS will never work with node http proxy.

[mmalecki]

Actually, now that I think about it, a DELETE request can have a body. We happen to use such requests ourselves in production.
We should check if a Content-Length is already defined, I think.
@indexzero @ian7 opinions?

[andreareginato]

That is true. I check is needed. I would add also OPTIONS (for CORS preflight) on the list of verbs to check.