Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Threaded RDSE #922

Open
aamir-gmail opened this issue Mar 14, 2021 · 5 comments
Open

Multi-Threaded RDSE #922

aamir-gmail opened this issue Mar 14, 2021 · 5 comments

Comments

@aamir-gmail
Copy link

Please confirm if RDSE encoder in single-threaded, if yes would you be open to making it multithreaded. I am encoding a lot of floating-point numbers through it and find it to be slow.

@dkeeney
Copy link

dkeeney commented Mar 14, 2021

Yes it is single threaded.
Yes, we are open to modifications that anyone would like to make to any algorithm.
All we ask is that it include a Unit Test that proves that it works, one that can be added to our regression test. Additional documentation is always useful. It must run on Linux, OSx, and Windows. When a Pull Request is posted, it will be reviewed and then merged. We tend to nit pick during the reviews but that makes for a better library.

None of the algorithms in the library are multi-threaded so be careful to make anything you use re-entrant and put locks on access to shared values... you probably know the drill.

@ctrl-z-9000-times
Copy link
Collaborator

Hi,

I took a look at the source code for the RDSE and I think it should be usable with multiple threads, under the following condition: The output SDR's are not used by multiple threads while they are being written to by the encoder.

@Thanh-Binh
Copy link

We have an own implementation of RDSE using lookup table, which is calculated very quickly only one time by initialization. So that we do not need any multithreaded!

@aamir-gmail
Copy link
Author

We have an own implementation of RDSE using lookup table, which is calculated very quickly only one time by initialization. So that we do not need any multithreaded!

Yes that what I ended up doing.

@aamir-gmail
Copy link
Author

I guess to keep this on your radar for future work, if there is nothing further to be added please close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants