-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDR should not auto-cast if vector provided instead of SDR as argument #416
Comments
see 127e385 |
I don't think we're going to be able to stop the compiler from doing this. We can detect this issue by checking the SDR's dimensions. Regardless of this bug, we should check SDR dimensions on most public facing API methods. |
would be nice if we could stop that behavior, if not, this should be documented somewhere (in SDR?) along with the advice to check SDR.dimensions |
@ctrl-z-9000-times You've mentioned the bug, and I ran into it in #397 with
cellsToColumns
Problem: compiler(?) converts a wrongly-passed type vector to a SDR if SDR is a method's argument.
Example:
Hint: I'd suspect some of SDR's default constructors, or assign operators
The text was updated successfully, but these errors were encountered: