OpenGL: Efficiency improvements for stencil commands #17478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
force-pushed
the
opengl-stencil-improvements
branch
from
1181798
to
3b81b3c
Compare
GPU/GLES/StateMappingGLES.cpp
Outdated
| @@ -302,6 +302,7 @@ void DrawEngineGLES::ApplyDrawState(int prim) { | |||
| void DrawEngineGLES::ApplyDrawStateLate(bool setStencilValue, int stencilValue) { | |||
| if (setStencilValue) { | |||
| render_->SetStencilFunc(GL_TRUE, GL_ALWAYS, stencilValue, 255); | |||
| render_->SetStencilOp(0xFF, GL_REPLACE, GL_REPLACE, GL_REPLACE); | |||
There was a problem hiding this comment.
This is actually partially wrong. When in clear mode, the stencil write mask is still applied (previously set by renderManager->SetStencilOp(stencilState.writeMask, GL_REPLACE, GL_REPLACE, GL_REPLACE);) Now it's no longer applied.
It'd be reasonable to apply it here though, not saying it doesn't make sense to do these together.
-[Unknown]
There was a problem hiding this comment.
darn, yeah you're right - should have figured that this will change behavior, of course.
I'll fix it up.
hrydgard
added a commit
that referenced
this pull request
Jun 12, 2023
Also renames vpAndScissor to vpAndScissor_ for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges the two stencil-state-setting commands, and dirty-tracks the individual parts.
While not big, compounds with the other recent OpenGL optimizations.
For merge after 1.15.x is done.