Add workaround for hung music notes in Rockman Dash 2 #16798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #11442. Or at least should, I haven't tested this, just followed the discussion in the issue. According to this issue, this is a game bug that happens on real hardware too, due to a lousy job porting the game to the PSP, most likely, which has different ADSR (note envelope) behavior.
|
@unknownbrackets could you just check that I understood your proposed change correctly? |
|
Well, this was more of a change to figure out what would work. I'd think more like #16810 if we want to enshrine it as a hack. -[Unknown] |
Sas: Adjust Rockman 2 sustain on init only
|
I think this one is motivated to enshrine as it clearly doesn't go against the intents of the creators of the game in any way while fixing a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11442. Or at least should, I haven't tested this, just followed the discussion in the issue.
According to this issue, this is a game bug that happens on real hardware too, due to a lousy job porting the game to the PSP, most likely, which has different ADSR (note envelope) behavior.