Additional Android cleanup #16644
Merged
Additional Android cleanup #16644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
force-pushed
the
additional-android-cleanup
branch
from
795185d
to
b7ffd7a
Compare
hrydgard
force-pushed
the
additional-android-cleanup
branch
from
b7ffd7a
to
f3c08c4
Compare
hrydgard
force-pushed
the
additional-android-cleanup
branch
from
f3c08c4
to
10c0b3f
Compare
| @@ -650,7 +655,7 @@ extern "C" void Java_org_ppsspp_ppsspp_NativeApp_init | |||
| EARLY_LOG("NativeApp.init() -- begin"); | |||
| PROFILE_INIT(); | |||
|
|
|||
| std::lock_guard<std::mutex> guard(renderLock); | |||
| std::lock_guard<std::mutex> guard(renderLock); // Note: This is held for the rest of this function - intended? | |||
There was a problem hiding this comment.
This only overlaps with shutdown and render, neither of which should start happening until init is done, IMHO. So it seems like a good thing for this lock to last the entire time.
That said, maybe we could run some more on the background or in a thread. I don't really think that would change this lock lifetime itself, but rather move other things out of this func directly.
-[Unknown]
unknownbrackets
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.