softgpu: Refactor imm prim handling to support fog/color1 #16042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3800b42
to
19e5f35
Compare
hrydgard
approved these changes
Sep 18, 2022
GPU/Software/SoftGpu.cpp
Outdated
| @@ -1138,6 +1145,18 @@ void SoftGPU::FinishDeferred() { | |||
| drawEngine_->transformUnit.Flush("finish"); | |||
| } | |||
|
|
|||
| int SoftGPU::ListSync(int listid, int mode) { | |||
| // Take this as a queue that we need to finish drawing. | |||
There was a problem hiding this comment.
D'oh, I type queue way more often than cue, this happens with several words heh.
-[Unknown]
We could in theory skip flush on FinishDeferred, and allow some CPU/GPU overlap. If we did, we'd still want to flush at these times.
The previous logic was harder to understand and easier to get wrong. Just drop them when clipping the primitive.
Only with through set, and we have to ignore position.
Was crashing because the frag and vert shaders didn't match up.
19e5f35
to
9f84cde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accurately handles what I've reproduced for immediate-mode primitives, stuffing them a bit later in the pipeline so they bypass vertex decode. There's still some ugliness for viewport (due to screenpos calculation after clipping), but it's not that terrible.
Ah, well, I'm not sure about the vertex Q, actually. Maybe texgen isn't right still...
The hardware renderers still don't support fog/color1, but I'm hoping this makes it easier for us to tell if some other game is using them unexpectedly. Anyway, I also want the software renderer to be a more accurate way to test graphics that might be used in PSP game patches.
This also means my imm fog test can be shown to pass and added to test.py (I think I forgot to ever push it...)
Also fixes a crash hardware renderers had if anything but rectangles were used in transform mode.
-[Unknown]